Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Use branch name substitution for all links #1031

Merged
merged 2 commits into from
May 27, 2023

Conversation

christophfroehlich
Copy link
Contributor

Using branch name substitutions now for every link.

For details see ros-controls/control.ros.org#98

@codecov-commenter
Copy link

Codecov Report

Merging #1031 (846280a) into master (925f5f3) will decrease coverage by 2.17%.
The diff coverage is 35.16%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #1031      +/-   ##
==========================================
- Coverage   34.61%   32.45%   -2.17%     
==========================================
  Files          52       92      +40     
  Lines        2981     9681    +6700     
  Branches     1855     6511    +4656     
==========================================
+ Hits         1032     3142    +2110     
- Misses        310      772     +462     
- Partials     1639     5767    +4128     
Flag Coverage Δ
unittests 32.45% <35.16%> (-2.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
controller_manager/src/controller_manager.cpp 38.23% <ø> (-1.48%) ⬇️
controller_manager/src/ros2_control_node.cpp 0.00% <0.00%> (ø)
..._interface/include/hardware_interface/actuator.hpp 100.00% <ø> (ø)
...ce/include/hardware_interface/async_components.hpp 0.00% <0.00%> (ø)
...re_interface/include/hardware_interface/sensor.hpp 100.00% <ø> (ø)
...re_interface/include/hardware_interface/system.hpp 100.00% <ø> (ø)
hardware_interface/src/resource_manager.cpp 47.16% <ø> (-6.47%) ⬇️
hardware_interface/src/sensor.cpp 50.52% <ø> (ø)
hardware_interface/src/system.cpp 55.45% <ø> (ø)
...rface/test/mock_components/test_generic_system.cpp 9.53% <ø> (ø)
... and 69 more

... and 19 files with indirect coverage changes

@bmagyar bmagyar merged commit 590de4e into ros-controls:master May 27, 2023
10 of 11 checks passed
@christophfroehlich christophfroehlich deleted the fix_links branch May 28, 2023 07:44
@christophfroehlich
Copy link
Contributor Author

@bmagyar backport humble pls :)

@bmagyar
Copy link
Member

bmagyar commented May 30, 2023

https://github.com/Mergifyio backport humble

@mergify
Copy link
Contributor

mergify bot commented May 30, 2023

backport humble

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request May 30, 2023
(cherry picked from commit 590de4e)

# Conflicts:
#	doc/index.rst
#	hardware_interface/doc/hardware_components_userdoc.rst
#	hardware_interface/doc/mock_components_userdoc.rst
#	hardware_interface/doc/writing_new_hardware_interface.rst
#	ros2controlcli/doc/userdoc.rst
bmagyar pushed a commit that referenced this pull request May 31, 2023
)

* Docs: Use branch name substitution for all links (#1031)

(cherry picked from commit 590de4e)

# Conflicts:
#	doc/index.rst
#	hardware_interface/doc/hardware_components_userdoc.rst
#	hardware_interface/doc/mock_components_userdoc.rst
#	hardware_interface/doc/writing_new_hardware_interface.rst
#	ros2controlcli/doc/userdoc.rst

* Fix merge conflicts (#1043)

---------

Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
flochre pushed a commit to flochre/ros2_control that referenced this pull request Jul 5, 2023
…ls#1031) (ros-controls#1042)

* Docs: Use branch name substitution for all links (ros-controls#1031)

(cherry picked from commit 590de4e)

# Conflicts:
#	doc/index.rst
#	hardware_interface/doc/hardware_components_userdoc.rst
#	hardware_interface/doc/mock_components_userdoc.rst
#	hardware_interface/doc/writing_new_hardware_interface.rst
#	ros2controlcli/doc/userdoc.rst

* Fix merge conflicts (ros-controls#1043)

---------

Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants