Fixes the issue with individual controller's update rate #1082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saikishor
changed the title
|
Are you planning to move to step # 2? ;) |
Hello @bmagyar! Yes, I've worked on it a bit. This weekend I was in the mountains and just arrived back this evening. I'll try to get something done this week. The problem is I'm trying to figure out a way to achieve the same without breaking ABI, and this is a bit challenging.😅 |
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #1082 +/- ##
==========================================
- Coverage 34.61% 32.46% -2.16%
==========================================
Files 52 94 +42
Lines 2981 9986 +7005
Branches 1855 6724 +4869
==========================================
+ Hits 1032 3242 +2210
- Misses 310 790 +480
- Partials 1639 5954 +4315
Flags with carried forward coverage won't be shown. Click here to find out more.
|
saikishor
force-pushed
the
fix_wrong_controller_update_rate
branch
from
925b09a
to
31f4f14
Compare
github-actions
bot
requested review from
bmagyar,
destogl,
jackcenter,
jaron-l,
livanov93,
mcbed and
mhubii
…er than the controller manager
bmagyar
reviewed
Jul 31, 2023
bmagyar
previously approved these changes
Jul 31, 2023
bmagyar
approved these changes
Aug 6, 2023
|
@Mergifyio backport humble |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Aug 7, 2023
* added parameterized test for the controller's update rate check * added warning for the update rate to be a perfect factor * fix the issue with the period when the controller update rate is higher than the controller manager (cherry picked from commit ad70c9a)
bmagyar
pushed a commit
that referenced
this pull request
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue of the wong update rate of the individual controller's update rate: #872
Here we will add a test to reproduce the issue, then add a proper fix.