-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sort controllers while configuring instead of while activating #1107
Sort controllers while configuring instead of while activating #1107
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1107 +/- ##
==========================================
+ Coverage 31.62% 31.78% +0.15%
==========================================
Files 94 94
Lines 10838 10804 -34
Branches 7419 7387 -32
==========================================
+ Hits 3428 3434 +6
+ Misses 804 792 -12
+ Partials 6606 6578 -28
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Is there consensus about doing this during configure? It makes sense to me, because read/write is also called in inactive state.
This pull request is in conflict. Could you fix it @saikishor? |
532d6b3
to
452da72
Compare
452da72
to
e029104
Compare
this is one thing and another thing is that in this stage we have enough information for sorting and call is not in the real-time loop. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not convinced about tests. I think we are losing some granularity in them. If you disagree, I am open to discuss that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for following up on this and explaining everything.
(cherry picked from commit 863f161) # Conflicts: # controller_manager/src/controller_manager.cpp # controller_manager/test/test_controller_manager_srvs.cpp
This PR aims to address the requirement of sorting all controllers that on configure rather than on switching them to active.