Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report inactive controllers as a diagnostics ok instead of an error #1184

Merged
merged 2 commits into from
Dec 4, 2023
Merged

Report inactive controllers as a diagnostics ok instead of an error #1184

merged 2 commits into from
Dec 4, 2023

Conversation

firesurfer
Copy link
Contributor

See #1183

@bmagyar bmagyar changed the title Report inactive controllers as a diagnostics warning instead of an error Report inactive controllers as a diagnostics ok instead of an error Dec 4, 2023
@bmagyar
Copy link
Member

bmagyar commented Dec 4, 2023

Everybody happy!

@bmagyar bmagyar merged commit c9bd3d8 into ros-controls:master Dec 4, 2023
12 checks passed
@bmagyar bmagyar added backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble. backport-iron This label should be used by maintaines only! Label triggers PR backport to ROS2 Iron. labels Dec 4, 2023
mergify bot pushed a commit that referenced this pull request Dec 4, 2023
@firesurfer @mergify
Report inactive controllers as a diagnostics ok instead of an error (#…
b873daf 
…1184)

(cherry picked from commit c9bd3d8)

# Conflicts:
#	controller_manager/src/controller_manager.cpp
mergify bot pushed a commit that referenced this pull request Dec 4, 2023
@firesurfer @mergify
Report inactive controllers as a diagnostics ok instead of an error (#…
e60a35c 
…1184)

(cherry picked from commit c9bd3d8)
This was referenced Dec 4, 2023
Closed
Merged
bmagyar pushed a commit that referenced this pull request Dec 4, 2023
@mergify @firesurfer
Report inactive controllers as a diagnostics ok instead of an error (#…
75cb8b8 
…1184) (#1190)

(cherry picked from commit c9bd3d8)

Co-authored-by: Lennart Nachtigall <firesurfer127@gmail.com>
@christophfroehlich christophfroehlich mentioned this pull request Dec 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saikishor saikishor saikishor left review comments

@bmagyar bmagyar bmagyar approved these changes

@destogl destogl Awaiting requested review from destogl

@duringhof duringhof Awaiting requested review from duringhof

@homalozoa homalozoa Awaiting requested review from homalozoa

@jaron-l jaron-l Awaiting requested review from jaron-l

@malapatiravi malapatiravi Awaiting requested review from malapatiravi

@mhubii mhubii Awaiting requested review from mhubii

Assignees
No one assigned
Labels
backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble. backport-iron This label should be used by maintaines only! Label triggers PR backport to ROS2 Iron.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@firesurfer @bmagyar @saikishor