-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cli interface #176
Add cli interface #176
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good.
I have a few comments, but nothing ground-braking :)
Are these python test files really needed? It looks like a lot of copy-paste action across many repositories (@Karsten1987 )?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's get the CI green
Codecov Report
@@ Coverage Diff @@
## master #176 +/- ##
=======================================
Coverage 34.61% 34.61%
=======================================
Files 52 52
Lines 2981 2981
Branches 1855 1855
=======================================
Hits 1032 1032
Misses 310 310
Partials 1639 1639
Flags with carried forward coverage won't be shown. Click here to find out more. |
Added command line interface for controller manager
Missing unit tests, waiting until we have a controller manager node or something similar like what is proposed on #147 or I could do them with mock services.
Implemented verbs:
list
list_types
load
reload_libraries
switch
unload