ResourceManager doesn't always log an error on shutdown anymore #867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
arne48,
bijoua29,
bmagyar,
DasRoteSkelett,
destogl,
livanov93 and
VX792
|
@destogl This remark should be fixed with this PR: https://github.com/ros-controls/ros2_control/blob/3.4.0/hardware_interface/test/test_resource_manager.cpp#L840 |
bmagyar
previously approved these changes
Dec 2, 2022
bmagyar
approved these changes
Dec 6, 2022
cwecht
pushed a commit
to cwecht/ros2_control
that referenced
this pull request
Dec 6, 2022
bmagyar
pushed a commit
that referenced
this pull request
Jan 6, 2023
#871) Co-authored-by: Christopher Wecht <christopher.wecht@itk-engineering.com>
pac48
pushed a commit
to pac48/ros2_control
that referenced
this pull request
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this fix, ResourceManager will always log messages like this on shutdown:
[INFO] [1669820165.720100008] [resource_manager]: 'shutdown' hardware 'TestSystemHardware' [INFO] [1669820165.720101920] [resource_manager]: Failed to 'shutdown' hardware 'TestSystemHardware'