Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spelling in comment #769

Merged
merged 1 commit into from Jul 11, 2022
Merged

Conversation

tylerjw
Copy link
Contributor

@tylerjw tylerjw commented Jul 10, 2022

Signed-off-by: Tyler Weaver tylerjw@gmail.com

Fix misspelling of the word calculating in comments in ros2_control_node. I'm sorry 😢

Signed-off-by: Tyler Weaver <tylerjw@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Merging #769 (5bdf78e) into master (925f5f3) will decrease coverage by 1.66%.
The diff coverage is 37.16%.

@@            Coverage Diff             @@
##           master     #769      +/-   ##
==========================================
- Coverage   34.61%   32.95%   -1.67%     
==========================================
  Files          52       89      +37     
  Lines        2981     8469    +5488     
  Branches     1855     5638    +3783     
==========================================
+ Hits         1032     2791    +1759     
- Misses        310      672     +362     
- Partials     1639     5006    +3367     
Flag Coverage Δ
unittests 32.95% <37.16%> (-1.67%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
controller_manager/src/realtime.cpp 0.00% <0.00%> (ø)
controller_manager/src/ros2_control_node.cpp 0.00% <0.00%> (ø)
..._interface/include/hardware_interface/actuator.hpp 100.00% <ø> (ø)
...re_interface/include/hardware_interface/sensor.hpp 100.00% <ø> (ø)
...re_interface/include/hardware_interface/system.hpp 100.00% <ø> (ø)
hardware_interface/src/resource_manager.cpp 50.09% <ø> (-3.53%) ⬇️
hardware_interface/src/sensor.cpp 50.52% <ø> (ø)
hardware_interface/src/system.cpp 55.45% <ø> (ø)
...rface/test/mock_components/test_generic_system.cpp 8.60% <ø> (ø)
...dware_interface/test/test_component_interfaces.cpp 32.44% <ø> (+4.25%) ⬆️
... and 105 more

Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We used to have codespell in the CI for this!

@bmagyar bmagyar merged commit 3e5d109 into ros-controls:master Jul 11, 2022
@bmagyar bmagyar mentioned this pull request Jul 15, 2022
pac48 pushed a commit to pac48/ros2_control that referenced this pull request Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants