Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update controller_interface/include/semantic_components/imu_sensor.hpp on master #893

Merged
merged 2 commits into from
Jan 11, 2023

Conversation

flochre
Copy link
Contributor

@flochre flochre commented Jan 10, 2023

Same as #889 but on master
Solving issue #888

flochre and others added 2 commits January 11, 2023 00:29
Covariances values should come from the IMU_Broadcaster, like the frame_id or the time
@bmagyar bmagyar enabled auto-merge (squash) January 11, 2023 09:51
@bmagyar
Copy link
Member

bmagyar commented Jan 11, 2023

@Mergifyio backport to humble

@mergify
Copy link
Contributor

mergify bot commented Jan 11, 2023

backport to humble

✅ Backports have been created

Copy link
Member

@destogl destogl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! Thanks!

@bmagyar bmagyar merged commit 6aae3e1 into ros-controls:master Jan 11, 2023
mergify bot pushed a commit that referenced this pull request Jan 11, 2023
Covariances values should come from the IMU_Broadcaster, like the frame_id or the time

(cherry picked from commit 6aae3e1)
bmagyar pushed a commit that referenced this pull request Jan 11, 2023
Covariances values should come from the IMU_Broadcaster, like the frame_id or the time

(cherry picked from commit 6aae3e1)

Co-authored-by: flochre <39066045+flochre@users.noreply.github.com>
@cwecht
Copy link
Contributor

cwecht commented Jan 19, 2023

@bmagyar I guess it makes sense to backport this patch directly to humble.

@bmagyar
Copy link
Member

bmagyar commented Jan 19, 2023

Absolutely! @Mergifyio backport to humble

@bmagyar
Copy link
Member

bmagyar commented Jan 19, 2023

Oh wait, it was already backported!:D my job is done here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants