-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update controller_interface/include/semantic_components/imu_sensor.hpp on master #893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Covariances values should come from the IMU_Broadcaster, like the frame_id or the time
github-actions
bot
requested review from
anfemosa,
arne48,
bmagyar,
DasRoteSkelett,
destogl,
jaron-l and
Serafadam
January 10, 2023 23:35
Closed
bmagyar
approved these changes
Jan 11, 2023
@Mergifyio backport to humble |
✅ Backports have been created
|
destogl
approved these changes
Jan 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch! Thanks!
mergify bot
pushed a commit
that referenced
this pull request
Jan 11, 2023
Covariances values should come from the IMU_Broadcaster, like the frame_id or the time (cherry picked from commit 6aae3e1)
bmagyar
pushed a commit
that referenced
this pull request
Jan 11, 2023
@bmagyar I guess it makes sense to backport this patch directly to humble. |
Absolutely! @Mergifyio backport to humble |
Oh wait, it was already backported!:D my job is done here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #889 but on master
Solving issue #888