Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation ERRORS #978

Closed
AmmarAlbakri opened this issue Mar 29, 2023 · 1 comment
Closed

Documentation ERRORS #978

AmmarAlbakri opened this issue Mar 29, 2023 · 1 comment

Comments

@AmmarAlbakri
Copy link

I was following the documentation: https://control.ros.org/master/doc/ros2_control/hardware_interface/doc/hardware_components_userdoc.html
for migrating the ros2_control hardware interface from foxy to galactic/humble, there are some typos and missing information in the documentation, I couldn't find where to submit this issue so I thought this is the best place.

Typos:

  • In step 12. rclcpp_lifecyle should be rclcpp_lifecycle
    Missing steps:
  • The read(); should be changed to read(const rclcpp::Time & time, const rclcpp::Duration & period);
  • The write(); should be changed to write(const rclcpp::Time & time, const rclcpp::Duration & period);
@bmagyar bmagyar removed the bug label Apr 11, 2023
@bmagyar
Copy link
Member

bmagyar commented Apr 11, 2023

pac48 pushed a commit to pac48/ros2_control that referenced this issue Jan 26, 2024
…'command_interfaces' parameters (ros-controls#967)" (ros-controls#978) (ros-controls#986)

This reverts commit 6e2736b0ed521e1b236dcf8ab2ede4ef565e97d4.

(cherry picked from commit 9f7e9e916ce8ae1403f0f0f5d108c80ea0242a9d)

Co-authored-by: Noel Jiménez García <noel.jimenez@pal-robotics.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants