Fix the controller sorting bug when the interfaces are not configured (fixes #1164)

[saikishor]

This PR:
Updates the tests to throw the exception on_configure as usual and then fixes with the appropriate condition checks to prevent the case mentioned in the #1164

[codecov]

Codecov Report

Merging #1165 (155969d) into master (0863acd) will decrease coverage by 0.01%.
The diff coverage is 28.57%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1165      +/-   ##
==========================================
- Coverage   47.65%   47.64%   -0.01%     
==========================================
  Files          40       40              
  Lines        3435     3442       +7     
  Branches     1860     1865       +5     
==========================================
+ Hits         1637     1640       +3     
  Misses        480      480              
- Partials     1318     1322       +4     

Flag	Coverage Δ
unittests	47.64% <28.57%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
controller_manager/src/controller_manager.cpp	38.72% <28.57%> (+0.02%)	⬆️

[fmauch]

Looks good and I tested this locally as mentioned in #1164 on Humble. As expected, this fixes the crash there.

On rolling I could not test things, as I ran into another issue there, that I first have to look at.

[saikishor]

Thank you for letting us know @fmauch

[fmauch]

@bmagyar Since the Humble sync is around the corner: Could we get this merged to Humble with priority? I posted a comment on the sync announcement about this.