fix regression in controller manager services #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
v-lopez
approved these changes
Sep 30, 2020
|
Why don't we have a clang CI? |
|
Btw let's be a little more specific, this I wouldn't consider a regression, that term is already wide enough in meaning that it's better if we limit it to tests. This is a simple build failure on clang. We could create all PRs with "fix regression" every time something doesn't work the way we intended in the past :D |
destogl
pushed a commit
to StoglRobotics-forks/ros2_control
that referenced
this pull request
Aug 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #139 (comment)
@v-lopez @bmagyar