Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing compiler definitions of RCPPUTILS_VERSION #1089

Merged

Conversation

saikishor
Copy link
Member

@saikishor saikishor commented Mar 26, 2024

Similar to ros-controls/ros2_control#1440, there is a missing compile definition of the rcpputils to use the proper non-deprecated namespace of RollingMeanAccumulator library starting from Humble, these compile definitions are needed to use the proper version.

I have opened a PR on rcpputils repo also to have the version.h header in their library, It's waiting to be merged, once it is merged, we can directly use the version.h instead of these compile definitions.

In file included from /home/user/ros2_control_state_itf_ws/src/ros2_controllers/tricycle_controller/include/tricycle_controller/tricycle_controller.hpp:43,
                 from /home/user/ros2_control_state_itf_ws/src/ros2_controllers/tricycle_controller/src/tricycle_controller.cpp:29:
/home/user/ros2_control_state_itf_ws/src/ros2_controllers/tricycle_controller/include/tricycle_controller/odometry.hpp:57:74: warning: ‘using RollingMeanAccumulator = class rcpputils::RollingMeanAccumulator<double>’ is deprecated: use rcpputils::RollingMeanAccumulator instead [-Wdeprecated-declarations]
   57 |   using RollingMeanAccumulator = rcppmath::RollingMeanAccumulator<double>;
      |                                                                          ^
In file included from /home/user/ros2_control_state_itf_ws/src/ros2_controllers/tricycle_controller/include/tricycle_controller/odometry.hpp:29,
                 from /home/user/ros2_control_state_itf_ws/src/ros2_controllers/tricycle_controller/include/tricycle_controller/tricycle_controller.hpp:43,
                 from /home/user/ros2_control_state_itf_ws/src/ros2_controllers/tricycle_controller/src/tricycle_controller.cpp:29:
/home/user/ros2_control_state_itf_ws/src/rcpputils/include/rcppmath/rolling_mean_accumulator.hpp:27:7: note: declared here
   27 | using RollingMeanAccumulator [[deprecated("use rcpputils::RollingMeanAccumulator instead")]] =
      |       ^~~~~~~~~~~~~~~~~~~~~~
In file included from /home/user/ros2_control_state_itf_ws/src/ros2_controllers/tricycle_controller/include/tricycle_controller/odometry.hpp:29,
                 from /home/user/ros2_control_state_itf_ws/src/ros2_controllers/tricycle_controller/include/tricycle_controller/tricycle_controller.hpp:43,
                 from /home/user/ros2_control_state_itf_ws/src/ros2_controllers/tricycle_controller/test/test_tricycle_controller.cpp:33:
/home/user/ros2_control_state_itf_ws/src/rcpputils/include/rcppmath/rolling_mean_accumulator.hpp:20:2: warning: #warning "the rcppmath namespace is deprecated, include rcpputils/rolling_mean_accumulator.hpp instead" [-Wcpp]
   20 | #warning \

Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine for me until ros2/rcpputils#190 gets merged.

@bmagyar bmagyar merged commit 689efe7 into ros-controls:master Mar 27, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants