Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate version header with ament_generate_version_header function #190

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Generate version header with ament_generate_version_header function #190

merged 1 commit into from
Mar 28, 2024

Conversation

saikishor
Copy link
Contributor

Calls the ament_cmake_gen_version_header function to generate and a header file containing rcpputils version information.

Provides compile-time version information for rcpputils!

If this can be merged and also backported to Iron and Humble. It would be really helpful

Thank you

@saikishor
Generate version header with ament_generate_version_header function
d9203f6 
Signed-off-by: Sai Kishor Kothakota <sai.kishor@pal-robotics.com>
@saikishor saikishor force-pushed the saikishor/ament_generate_version_header branch from 44ab441 to d9203f6 Compare March 19, 2024 12:41
@saikishor
Copy link
Contributor Author

The failing tests are due to uncrustify and flake8 and seem like they are not related to the changes in this PR

fujitatomoya
fujitatomoya approved these changes Mar 19, 2024
View reviewed changes
Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think that is fine to have rcpputils/version.h.

@gavanderhoorn gavanderhoorn mentioned this pull request Mar 26, 2024
Merged
@christophfroehlich christophfroehlich mentioned this pull request Mar 27, 2024
Merged
@fujitatomoya
Copy link
Collaborator

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@fujitatomoya fujitatomoya merged commit bc0e3cf into ros2:rolling Mar 28, 2024
2 of 3 checks passed
@saikishor
Copy link
Contributor Author

@fujitatomoya Can this be backported to Humble and Iron as well?

Thank you

@fujitatomoya
Copy link
Collaborator

@Mergifyio backport humble iron

@mergify Mergify
Copy link

mergify bot commented Mar 30, 2024 •
edited
Loading

backport humble iron

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Mar 30, 2024
@saikishor @mergify
Generate version header with ament_generate_version_header function (#…
6978af7 
…190)

Signed-off-by: Sai Kishor Kothakota <sai.kishor@pal-robotics.com>
(cherry picked from commit bc0e3cf)
@mergify mergify bot mentioned this pull request Mar 30, 2024
Merged
mergify bot pushed a commit that referenced this pull request Mar 30, 2024
@saikishor @mergify
Generate version header with ament_generate_version_header function (#…
63e3300 
…190)

Signed-off-by: Sai Kishor Kothakota <sai.kishor@pal-robotics.com>
(cherry picked from commit bc0e3cf)
@mergify mergify bot mentioned this pull request Mar 30, 2024
Merged
clalancette pushed a commit that referenced this pull request Apr 22, 2024
@mergify @saikishor
Generate version header with ament_generate_version_header function (#…
ce87fc2 
…190) (#191)

Signed-off-by: Sai Kishor Kothakota <sai.kishor@pal-robotics.com>
(cherry picked from commit bc0e3cf)

Co-authored-by: Sai Kishor Kothakota <saisastra3@gmail.com>
clalancette pushed a commit that referenced this pull request May 17, 2024
@mergify @saikishor
Generate version header with ament_generate_version_header function (#…
eab7df2 
…190) (#192)

Signed-off-by: Sai Kishor Kothakota <sai.kishor@pal-robotics.com>
(cherry picked from commit bc0e3cf)

Co-authored-by: Sai Kishor Kothakota <saisastra3@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fujitatomoya fujitatomoya fujitatomoya approved these changes

@methylDragon methylDragon Awaiting requested review from methylDragon methylDragon is a code owner

@wjwwood wjwwood Awaiting requested review from wjwwood wjwwood is a code owner

Assignees

@fujitatomoya fujitatomoya

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saikishor @fujitatomoya