Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add imu sensor broadcaster #195

Merged
merged 6 commits into from
Jun 28, 2021
Merged

Add imu sensor broadcaster #195

merged 6 commits into from
Jun 28, 2021

Conversation

v-lopez
Copy link
Contributor

@v-lopez v-lopez commented Jun 4, 2021

No description provided.

@v-lopez v-lopez force-pushed the add-imu-sensor-broadcaster branch from 8223e87 to 57dd706 Compare June 7, 2021 07:27
destogl
destogl approved these changes Jun 7, 2021
View reviewed changes
Copy link
Member

@destogl destogl left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, just two non-mandatory comments.

Thanks!

imu_sensor_broadcaster/doc/userdoc.rst Show resolved Hide resolved
imu_sensor_broadcaster/src/imu_sensor_broadcaster.cpp Show resolved Hide resolved
destogl
destogl approved these changes Jun 8, 2021
View reviewed changes
Copy link
Member

@destogl destogl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine with it. We just need to correct this flaky test.

@v-lopez v-lopez mentioned this pull request Jun 8, 2021
Merged
@bmagyar bmagyar force-pushed the add-imu-sensor-broadcaster branch from 6e494d7 to 1638ccd Compare June 28, 2021 07:34
bmagyar
bmagyar approved these changes Jun 28, 2021
View reviewed changes
Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are sufficiently stable now

@bmagyar bmagyar merged commit 2b425fa into ros-controls:master Jun 28, 2021
gwalck pushed a commit to StoglRobotics-forks/ros2_controllers that referenced this pull request Jun 7, 2023
@mattnds
Rename hardware_interface::status issue 179 (ros-controls#195)
3759996
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@destogl destogl destogl approved these changes

@bmagyar bmagyar bmagyar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@v-lopez @destogl @bmagyar