Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate params for ForceTorqueSensorBroadcaster #395

Merged
merged 8 commits into from Aug 27, 2022

Conversation

tylerjw
Copy link
Contributor

@tylerjw tylerjw commented Jul 27, 2022

Signed-off-by: Tyler Weaver tyler@picknik.ai

Another PR to adapt a controller to use GenerateParameterLibrary

@mergify
Copy link
Contributor

mergify bot commented Aug 10, 2022

This pull request is in conflict. Could you fix it @tylerjw?

Copy link
Member

@destogl destogl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few proposals to make this even more better! Thanks for all the work!

@destogl destogl changed the title Generate params for Force Torque Sensor Generate params for ForceTorqueSensorBroadcaster Aug 16, 2022
tylerjw and others added 3 commits August 17, 2022 10:48
Signed-off-by: Tyler Weaver <tyler@picknik.ai>
Co-authored-by: Denis Štogl <denis@stogl.de>
Signed-off-by: Tyler Weaver <tyler@picknik.ai>
@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2022

Codecov Report

Merging #395 (d1ba918) into master (e7f9962) will decrease coverage by 5.79%.
The diff coverage is 20.65%.

@@            Coverage Diff             @@
##           master     #395      +/-   ##
==========================================
- Coverage   35.78%   29.98%   -5.80%     
==========================================
  Files         189        7     -182     
  Lines       17570      737   -16833     
  Branches    11592      422   -11170     
==========================================
- Hits         6287      221    -6066     
+ Misses        994      161     -833     
+ Partials    10289      355    -9934     
Flag Coverage Δ
unittests 29.98% <20.65%> (-5.80%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...de/diff_drive_controller/diff_drive_controller.hpp 100.00% <ø> (ø)
...ontroller/test/test_load_diff_drive_controller.cpp 12.50% <0.00%> (ø)
diff_drive_controller/src/odometry.cpp 42.16% <11.11%> (ø)
...ive_controller/test/test_diff_drive_controller.cpp 17.62% <12.08%> (ø)
diff_drive_controller/src/speed_limiter.cpp 46.55% <13.33%> (ø)
...troller/include/diff_drive_controller/odometry.hpp 20.00% <20.00%> (ø)
...iff_drive_controller/src/diff_drive_controller.cpp 32.67% <24.89%> (ø)
...include/joint_trajectory_controller/trajectory.hpp
...lers/test/test_joint_group_position_controller.cpp
...nt_state_controller/src/joint_state_controller.cpp
... and 192 more

Copy link
Contributor

@erickisos erickisos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments to help you fix some of the linter issues in case your local configuration doesn't match the expected format.

👏

diff_drive_controller/src/diff_drive_controller.cpp Outdated Show resolved Hide resolved
diff_drive_controller/src/diff_drive_controller.cpp Outdated Show resolved Hide resolved
diff_drive_controller/src/diff_drive_controller.cpp Outdated Show resolved Hide resolved
diff_drive_controller/src/diff_drive_controller.cpp Outdated Show resolved Hide resolved
diff_drive_controller/src/diff_drive_controller.cpp Outdated Show resolved Hide resolved
tricycle_controller/src/tricycle_controller.cpp Outdated Show resolved Hide resolved
tricycle_controller/src/tricycle_controller.cpp Outdated Show resolved Hide resolved
tricycle_controller/src/tricycle_controller.cpp Outdated Show resolved Hide resolved
tricycle_controller/src/tricycle_controller.cpp Outdated Show resolved Hide resolved
tricycle_controller/src/tricycle_controller.cpp Outdated Show resolved Hide resolved
@destogl
Copy link
Member

destogl commented Aug 22, 2022

I left some comments to help you fix some of the linter issues in case your local configuration doesn't match the expected format.

@erickisos thanks! But this was unfortunately not the issue with formatting. Now we should have everything correct.

@tylerjw
Copy link
Contributor Author

tylerjw commented Aug 22, 2022

I am developing on ubuntu 22.04 with Humble and/or Rolling and I believe I have all the required linters correctly installed. Is there a guide somewhere?

It seems that CI is not catching changes to formatting and I have submitted several small PRs to fix formatting since I started working on this change.

@bmagyar bmagyar merged commit 5e6ef29 into ros-controls:master Aug 27, 2022
@tylerjw tylerjw deleted the fts_params branch August 27, 2022 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants