New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate params for ForceTorqueSensorBroadcaster #395
Conversation
This pull request is in conflict. Could you fix it @tylerjw? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few proposals to make this even more better! Thanks for all the work!
force_torque_sensor_broadcaster/src/force_torque_sensor_broadcaster.cpp
Outdated
Show resolved
Hide resolved
force_torque_sensor_broadcaster/src/force_torque_sensor_broadcaster.cpp
Outdated
Show resolved
Hide resolved
force_torque_sensor_broadcaster/src/force_torque_sensor_broadcaster.cpp
Outdated
Show resolved
Hide resolved
force_torque_sensor_broadcaster/src/force_torque_sensor_broadcaster_parameters.yaml
Show resolved
Hide resolved
force_torque_sensor_broadcaster/src/force_torque_sensor_broadcaster_parameters.yaml
Show resolved
Hide resolved
force_torque_sensor_broadcaster/src/force_torque_sensor_broadcaster_parameters.yaml
Show resolved
Hide resolved
force_torque_sensor_broadcaster/src/force_torque_sensor_broadcaster_parameters.yaml
Show resolved
Hide resolved
force_torque_sensor_broadcaster/src/force_torque_sensor_broadcaster_parameters.yaml
Show resolved
Hide resolved
force_torque_sensor_broadcaster/src/force_torque_sensor_broadcaster_parameters.yaml
Show resolved
Hide resolved
force_torque_sensor_broadcaster/src/force_torque_sensor_broadcaster_parameters.yaml
Show resolved
Hide resolved
Signed-off-by: Tyler Weaver <tyler@picknik.ai>
Co-authored-by: Denis Štogl <denis@stogl.de>
Signed-off-by: Tyler Weaver <tyler@picknik.ai>
Codecov Report
@@ Coverage Diff @@
## master #395 +/- ##
==========================================
- Coverage 35.78% 29.98% -5.80%
==========================================
Files 189 7 -182
Lines 17570 737 -16833
Branches 11592 422 -11170
==========================================
- Hits 6287 221 -6066
+ Misses 994 161 -833
+ Partials 10289 355 -9934
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Tyler Weaver <tyler@picknik.ai>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments to help you fix some of the linter issues in case your local configuration doesn't match the expected format.
👏
@erickisos thanks! But this was unfortunately not the issue with formatting. Now we should have everything correct. |
I am developing on ubuntu 22.04 with Humble and/or Rolling and I believe I have all the required linters correctly installed. Is there a guide somewhere? It seems that CI is not catching changes to formatting and I have submitted several small PRs to fix formatting since I started working on this change. |
Signed-off-by: Tyler Weaver tyler@picknik.ai
Another PR to adapt a controller to use GenerateParameterLibrary