Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecation warning when parameter without value is set. #445

Merged
merged 1 commit into from
Oct 8, 2022

Conversation

destogl
Copy link
Member

@destogl destogl commented Oct 8, 2022

Without this change newest Rolling gives the following warning:

[publisher_joint_trajectory_controller-1] /opt/ros/rolling/local/lib/python3.10/dist-packages/rclpy/node.py:462: UserWarning: when declaring parameter named 'pos4', declaring a parameter only providing its name is deprecated. You have to either:
[publisher_joint_trajectory_controller-1]       - Pass a name and a default value different to "PARAMETER NOT SET" (and optionally a descriptor).
[publisher_joint_trajectory_controller-1]       - Pass a name and a parameter type.
[publisher_joint_trajectory_controller-1]       - Pass a name and a descriptor with `dynamic_typing=True

@codecov-commenter
Copy link

Codecov Report

Merging #445 (bd79979) into master (e7f9962) will decrease coverage by 5.79%.
The diff coverage is 20.65%.

@@            Coverage Diff             @@
##           master     #445      +/-   ##
==========================================
- Coverage   35.78%   29.98%   -5.80%     
==========================================
  Files         189        7     -182     
  Lines       17570      737   -16833     
  Branches    11592      422   -11170     
==========================================
- Hits         6287      221    -6066     
+ Misses        994      161     -833     
+ Partials    10289      355    -9934     
Flag Coverage Δ
unittests 29.98% <20.65%> (-5.80%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...de/diff_drive_controller/diff_drive_controller.hpp 100.00% <ø> (ø)
...ontroller/test/test_load_diff_drive_controller.cpp 12.50% <0.00%> (ø)
diff_drive_controller/src/odometry.cpp 42.16% <11.11%> (ø)
...ive_controller/test/test_diff_drive_controller.cpp 17.62% <12.08%> (ø)
diff_drive_controller/src/speed_limiter.cpp 46.55% <13.33%> (ø)
...troller/include/diff_drive_controller/odometry.hpp 20.00% <20.00%> (ø)
...iff_drive_controller/src/diff_drive_controller.cpp 32.67% <24.89%> (ø)
...test/test_load_joint_group_velocity_controller.cpp
...jectory_controller/joint_trajectory_controller.hpp
...int_trajectory_controller/test/test_trajectory.cpp
... and 192 more

@bmagyar bmagyar merged commit 34da157 into master Oct 8, 2022
@bmagyar bmagyar deleted the remove-deprecation-warning branch October 8, 2022 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants