Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMU Broadcaster] Added parameters for definition of static covariances. #455

Conversation

destogl
Copy link
Member

@destogl destogl commented Oct 21, 2022

Sits on top of #399 that should be merged first.

@mergify
Copy link
Contributor

mergify bot commented Oct 21, 2022

This pull request is in conflict. Could you fix it @destogl?

@bmagyar bmagyar force-pushed the added-parameters-for-static-covariances branch from bb7055a to 5180b49 Compare October 21, 2022 05:30
Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

me gusta

@codecov-commenter
Copy link

Codecov Report

Merging #455 (4048550) into master (e7f9962) will decrease coverage by 5.79%.
The diff coverage is 20.65%.

@@            Coverage Diff             @@
##           master     #455      +/-   ##
==========================================
- Coverage   35.78%   29.98%   -5.80%     
==========================================
  Files         189        7     -182     
  Lines       17570      737   -16833     
  Branches    11592      422   -11170     
==========================================
- Hits         6287      221    -6066     
+ Misses        994      161     -833     
+ Partials    10289      355    -9934     
Flag Coverage Δ
unittests 29.98% <20.65%> (-5.80%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...de/diff_drive_controller/diff_drive_controller.hpp 100.00% <ø> (ø)
...ontroller/test/test_load_diff_drive_controller.cpp 12.50% <0.00%> (ø)
diff_drive_controller/src/odometry.cpp 42.16% <11.11%> (ø)
...ive_controller/test/test_diff_drive_controller.cpp 17.62% <12.08%> (ø)
diff_drive_controller/src/speed_limiter.cpp 46.55% <13.33%> (ø)
...troller/include/diff_drive_controller/odometry.hpp 20.00% <20.00%> (ø)
...iff_drive_controller/src/diff_drive_controller.cpp 32.67% <24.89%> (ø)
...ontrollers/src/joint_group_position_controller.cpp
...mand_controller/src/forward_command_controller.cpp
...jectory_controller/joint_trajectory_controller.hpp
... and 192 more

@bmagyar bmagyar merged commit 3f9f550 into ros-controls:master Oct 21, 2022
@destogl destogl deleted the added-parameters-for-static-covariances branch October 21, 2022 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants