Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use optional from C++17 #460

Merged
merged 1 commit into from
Nov 2, 2022
Merged

Conversation

bmagyar
Copy link
Member

@bmagyar bmagyar commented Nov 2, 2022

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Nov 2, 2022

Codecov Report

Merging #460 (96f0337) into master (e7f9962) will decrease coverage by 5.79%.
The diff coverage is 20.65%.

@@            Coverage Diff             @@
##           master     #460      +/-   ##
==========================================
- Coverage   35.78%   29.98%   -5.80%     
==========================================
  Files         189        7     -182     
  Lines       17570      737   -16833     
  Branches    11592      422   -11170     
==========================================
- Hits         6287      221    -6066     
+ Misses        994      161     -833     
+ Partials    10289      355    -9934     
Flag Coverage Δ
unittests 29.98% <20.65%> (-5.80%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...de/diff_drive_controller/diff_drive_controller.hpp 100.00% <ø> (ø)
...ontroller/test/test_load_diff_drive_controller.cpp 12.50% <0.00%> (ø)
diff_drive_controller/src/odometry.cpp 42.16% <11.11%> (ø)
...ive_controller/test/test_diff_drive_controller.cpp 17.62% <12.08%> (ø)
diff_drive_controller/src/speed_limiter.cpp 46.55% <13.33%> (ø)
...troller/include/diff_drive_controller/odometry.hpp 20.00% <20.00%> (ø)
...iff_drive_controller/src/diff_drive_controller.cpp 32.67% <24.89%> (ø)
...mand_controller/src/forward_command_controller.cpp
...include/joint_trajectory_controller/tolerances.hpp
...ntroller/test/test_load_joint_state_controller.cpp
... and 192 more

@destogl destogl merged commit 12160de into ros-controls:master Nov 2, 2022
@destogl
Copy link
Member

destogl commented Nov 2, 2022

@Mergifyio backport humble

@mergify
Copy link
Contributor

mergify bot commented Nov 2, 2022

backport humble

❌ No backport have been created

  • Backport to branch humble failed: Branch not found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants