Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JTC] Add pid gain structure to documentation #485

Merged
merged 3 commits into from
Jan 10, 2023
Merged

[JTC] Add pid gain structure to documentation #485

merged 3 commits into from
Jan 10, 2023

Conversation

christophfroehlich
Copy link
Contributor

I also described the used control law briefly.

@codecov-commenter
Copy link

codecov-commenter commented Dec 28, 2022 •
edited

Codecov Report

Merging #485 (5a79b5a) into master (e7f9962) will decrease coverage by 3.30%.
The diff coverage is 26.60%.

@@            Coverage Diff             @@
##           master     #485      +/-   ##
==========================================
- Coverage   35.78%   32.48%   -3.31%     
==========================================
  Files         189        7     -182     
  Lines       17570      665   -16905     
  Branches    11592      357   -11235     
==========================================
- Hits         6287      216    -6071     
+ Misses        994      157     -837     
+ Partials    10289      292    -9997
Flag Coverage Δ
unittests 32.48% <26.60%> (-3.31%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ontroller/test/test_load_diff_drive_controller.cpp 12.50% <0.00%> (ø)
diff_drive_controller/src/odometry.cpp 42.16% <11.11%> (ø)
diff_drive_controller/src/speed_limiter.cpp 46.55% <11.11%> (ø)
...ive_controller/test/test_diff_drive_controller.cpp 17.62% <12.08%> (ø)
...troller/include/diff_drive_controller/odometry.hpp 20.00% <20.00%> (ø)
...iff_drive_controller/src/diff_drive_controller.cpp 39.22% <35.50%> (ø)
...de/diff_drive_controller/diff_drive_controller.hpp 100.00% <100.00%> (ø)
...ontroller/test/test_forward_command_controller.cpp
...ntroller/test/test_load_joint_state_controller.cpp
...dcaster/test/test_load_joint_state_broadcaster.cpp
... and 191 more

destogl
destogl approved these changes Jan 9, 2023
View reviewed changes
Copy link
Member

@destogl destogl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

joint_trajectory_controller/doc/userdoc.rst Outdated
@@ -140,29 +140,64 @@ open_loop_control (boolean):

If this flag is set, the controller tries to read the values from the command interfaces on starting. If they have real numeric values, those will be used instead of state interfaces. Therefore it is important set command interfaces to NaN (std::numeric_limits<double>::quiet_NaN()) or state values when the hardware is started.

constraints (structure)
constraints (structure):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure what I like more, with or without :

You can decide :D

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are right, looks nicer without ;)

@destogl destogl enabled auto-merge (squash) January 9, 2023 21:32
auto-merge was automatically disabled January 9, 2023 21:52

Head branch was pushed to by a user without write access

@bmagyar bmagyar merged commit e0a373a into ros-controls:master Jan 10, 2023
@christophfroehlich
Copy link
Contributor Author

@Mergifyio backport humble

@mergify
Copy link
Contributor

mergify bot commented Mar 7, 2023

backport humble

❌ Command disallowed due to command restrictions in the Mergify configuration.

  • sender-permission>=write

@christophfroehlich christophfroehlich deleted the jtc_documentation branch March 7, 2023 19:42
@bmagyar
Copy link
Member

bmagyar commented Mar 7, 2023

@Mergifyio backport humble

@mergify
Copy link
Contributor

mergify bot commented Mar 7, 2023 •
edited

backport humble

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Mar 7, 2023
@christophfroehlich @mergify
[JTC] Add pid gain structure to documentation (#485)
78d42c5 
* Add pid gain structure to documentation

* Remove trailing whitespace

* Remove trailing colons

(cherry picked from commit e0a373a)
@mergify mergify bot mentioned this pull request Mar 7, 2023
Merged
bmagyar pushed a commit that referenced this pull request Mar 9, 2023
@mergify @christophfroehlich
[JTC] Add pid gain structure to documentation (#485) (#543)
f6b0ec4 
* Add pid gain structure to documentation

* Remove trailing whitespace

* Remove trailing colons

(cherry picked from commit e0a373a)

Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
@destogl destogl mentioned this pull request May 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@destogl destogl destogl approved these changes

@bmagyar bmagyar bmagyar approved these changes

@aprotyas aprotyas Awaiting requested review from aprotyas

@bijoua29 bijoua29 Awaiting requested review from bijoua29

@DasRoteSkelett DasRoteSkelett Awaiting requested review from DasRoteSkelett

@harderthan harderthan Awaiting requested review from harderthan

@VX792 VX792 Awaiting requested review from VX792

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@christophfroehlich @codecov-commenter @bmagyar @destogl