diff_drive base_frame_id param - default value

[delihus]

I think the most common base_frame_id would be the base_link value.
Furthermore the default diff_drive_controller parameters make odom -> odom transform.

Found issue:
#482

[bmagyar]

Thanks and good catch!

[codecov-commenter]

Codecov Report

Merging #495 (4bb7fb6) into master (e7f9962) will decrease coverage by 3.30%.
The diff coverage is 26.60%.

@@            Coverage Diff             @@
##           master     #495      +/-   ##
==========================================
- Coverage   35.78%   32.48%   -3.31%     
==========================================
  Files         189        7     -182     
  Lines       17570      665   -16905     
  Branches    11592      357   -11235     
==========================================
- Hits         6287      216    -6071     
+ Misses        994      157     -837     
+ Partials    10289      292    -9997     

Flag	Coverage Δ
unittests	32.48% <26.60%> (-3.31%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...ontroller/test/test_load_diff_drive_controller.cpp	12.50% <0.00%> (ø)
diff_drive_controller/src/odometry.cpp	42.16% <11.11%> (ø)
diff_drive_controller/src/speed_limiter.cpp	46.55% <11.11%> (ø)
...ive_controller/test/test_diff_drive_controller.cpp	17.62% <12.08%> (ø)
...troller/include/diff_drive_controller/odometry.hpp	20.00% <20.00%> (ø)
...iff_drive_controller/src/diff_drive_controller.cpp	39.22% <35.50%> (ø)
...de/diff_drive_controller/diff_drive_controller.hpp	100.00% <100.00%> (ø)
...int_trajectory_controller/test/test_trajectory.cpp
...ontrollers/src/joint_group_position_controller.cpp
...ectory_controller/test/test_trajectory_actions.cpp
... and 191 more

[destogl]

Great catch! Thank you very much!

[destogl]

@Mergifyio backport humble

[mergify]

backport humble

✅ Backports have been created

• #498 diff_drive base_frame_id param - default value (backport #495) has been created for branch humble