Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sphinx for steering odometry library/controllers #626

Merged
merged 1 commit into from May 28, 2023

Conversation

christophfroehlich
Copy link
Contributor

I fixed the links for the new docs from #484

@christophfroehlich
Copy link
Contributor Author

pls also backport to humble after #624

@codecov-commenter
Copy link

Codecov Report

Merging #626 (565563a) into master (e7f9962) will increase coverage by 0.20%.
The diff coverage is 33.82%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master     #626      +/-   ##
==========================================
+ Coverage   35.78%   35.98%   +0.20%     
==========================================
  Files         189        7     -182     
  Lines       17570      678   -16892     
  Branches    11592      362   -11230     
==========================================
- Hits         6287      244    -6043     
+ Misses        994      134     -860     
+ Partials    10289      300    -9989     
Flag Coverage Δ
unittests 35.98% <33.82%> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ontroller/test/test_load_diff_drive_controller.cpp 11.11% <0.00%> (ø)
diff_drive_controller/src/odometry.cpp 42.16% <11.11%> (ø)
diff_drive_controller/src/speed_limiter.cpp 46.55% <11.11%> (ø)
...ive_controller/test/test_diff_drive_controller.cpp 17.62% <12.08%> (ø)
...iff_drive_controller/src/diff_drive_controller.cpp 45.76% <45.02%> (ø)
...de/diff_drive_controller/diff_drive_controller.hpp 100.00% <100.00%> (ø)
...troller/include/diff_drive_controller/odometry.hpp 100.00% <100.00%> (ø)

... and 189 files with indirect coverage changes

Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@bmagyar bmagyar merged commit a3f2a16 into ros-controls:master May 28, 2023
11 of 13 checks passed
@christophfroehlich christophfroehlich deleted the fix_sphinx branch May 28, 2023 14:23
@destogl
Copy link
Member

destogl commented May 31, 2023

@Mergifyio backport humble

@mergify
Copy link
Contributor

mergify bot commented May 31, 2023

backport humble

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request May 31, 2023
(cherry picked from commit a3f2a16)

# Conflicts:
#	ackermann_steering_controller/doc/userdoc.rst
#	bicycle_steering_controller/doc/userdoc.rst
#	steering_controllers_library/doc/userdoc.rst
#	tricycle_steering_controller/doc/userdoc.rst
christophfroehlich added a commit to christophfroehlich/ros2_controllers that referenced this pull request Jun 12, 2023
bmagyar pushed a commit that referenced this pull request Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants