Broadcaster parameters #650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
anfemosa,
aprotyas,
arne48,
bmagyar,
destogl,
duringhof and
progtologist
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #650 +/- ##
==========================================
+ Coverage 35.78% 36.53% +0.75%
==========================================
Files 189 7 -182
Lines 17570 676 -16894
Branches 11592 357 -11235
==========================================
- Hits 6287 247 -6040
+ Misses 994 134 -860
+ Partials 10289 295 -9994
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
This pull request is in conflict. Could you fix it @christophfroehlich? |
bmagyar
requested changes
Jun 12, 2023
force_torque_sensor_broadcaster/test/test_force_torque_sensor_broadcaster.cpp
Outdated
Show resolved
Hide resolved
force_torque_sensor_broadcaster/test/test_load_force_torque_sensor_broadcaster.cpp
Outdated
Show resolved
Hide resolved
Co-authored-by: Bence Magyar <bence.magyar.robotics@gmail.com>
imu_sensor_broadcaster/test/test_load_imu_sensor_broadcaster.cpp
Outdated
Show resolved
Hide resolved
christophfroehlich
added
the
backport-humble
mergify bot
pushed a commit
that referenced
this pull request
Jun 14, 2023
(cherry picked from commit f059022) # Conflicts: # force_torque_sensor_broadcaster/test/test_load_force_torque_sensor_broadcaster.cpp # imu_sensor_broadcaster/test/test_load_imu_sensor_broadcaster.cpp
christophfroehlich
added a commit
to christophfroehlich/ros2_controllers
that referenced
this pull request
Jun 17, 2023
bmagyar
pushed a commit
that referenced
this pull request
Jun 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
imu_sensor_broadcasterandforce_torque_sensor_broadcasterhad parameters manually parsed for being non-empty. I added them to the generate_parameter_library yaml and updated the tests accordingly.