Fix out of bound access in admittance controller #721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
bijoua29,
bmagyar,
destogl,
harderthan,
jackcenter,
mhubii and
progtologist
sea-bass
reviewed
Jul 26, 2023
admittance_controller/include/admittance_controller/admittance_rule_impl.hpp
Outdated
Show resolved
Hide resolved
Abishalini
force-pushed
the
pr-fix-admittance-stiffness-bug
branch
from
f123bae
to
66fbee3
Compare
|
I have retargeted the changes to go in the master branch. |
bmagyar
added
the
backport-humble
sea-bass
approved these changes
Jul 27, 2023
bmagyar
reviewed
Jul 27, 2023
admittance_controller/include/admittance_controller/admittance_rule_impl.hpp
Outdated
Show resolved
Hide resolved
mergify bot
pushed a commit
that referenced
this pull request
Jul 27, 2023
(cherry picked from commit 76c22ff)
bmagyar
pushed a commit
that referenced
this pull request
Jul 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the number of robot joints is more than 6, admittance controller currently segfaults with an out-of-bound access error.
This PR moves a few state updates out of the loop which iterates over the number of joint states.