[JTC] Fix typos, implicit cast, const member functions

[christophfroehlich]

Fix typos, implicit cast warnings, and declare const member functions as const

[codecov-commenter]

Codecov Report

Merging #748 (472a1a0) into master (e7f9962) will decrease coverage by 4.90%.
Report is 355 commits behind head on master.
The diff coverage is 25.91%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master     #748      +/-   ##
==========================================
- Coverage   35.78%   30.88%   -4.90%     
==========================================
  Files         189        7     -182     
  Lines       17570      832   -16738     
  Branches    11592      505   -11087     
==========================================
- Hits         6287      257    -6030     
+ Misses        994      133     -861     
+ Partials    10289      442    -9847     

Flag	Coverage Δ
unittests	30.88% <25.91%> (-4.90%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
...ontroller/test/test_load_diff_drive_controller.cpp	11.11% <0.00%> (ø)
...ive_controller/test/test_diff_drive_controller.cpp	12.66% <7.81%> (ø)
diff_drive_controller/src/odometry.cpp	42.16% <11.11%> (ø)
diff_drive_controller/src/speed_limiter.cpp	46.55% <11.11%> (ø)
...iff_drive_controller/src/diff_drive_controller.cpp	47.13% <46.94%> (ø)
...de/diff_drive_controller/diff_drive_controller.hpp	100.00% <100.00%> (ø)
...troller/include/diff_drive_controller/odometry.hpp	100.00% <100.00%> (ø)

... and 189 files with indirect coverage changes

[saikishor]

LGTM

[saikishor]

It is weird that CI says that the changes break ABI. I don't see any ABI breaking changes.

Thanks for the changes

[christophfroehlich]

It is weird that CI says that the changes break ABI. I don't see any ABI breaking changes.

I guess that the const qualifiers change ABI?

has_active_trajectory from #558 has not been released until now, and the other methods are for testing only -> don't see any problem changing this now.

[saikishor]

I guess that the const qualifiers change ABI?

Ideally it shouldn't, but I might be wrong

Anyway, this is local to the controller and it is not used as a library, so we can go ahead with the PR

[bmagyar]

Very good, thank you!