[ForceTorqueSensorBroadcaster] Create ParamListener and get parameters on configure (backport #698) #750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
github-actions
bot
requested review from
bmagyar,
destogl,
homalozoa,
jaron-l,
malapatiravi,
mcbed and
rosterloh
This was referenced Oct 30, 2023
destogl
approved these changes
Nov 6, 2023
…s on configure (#698) * Create ParamListener and get parameters on configure * Declare parameters for test_force_torque_sensor_broadcaster Since the parameters are not declared on init anymore, they cannot be set without declaring them before --------- Co-authored-by: Bence Magyar <bence.magyar.robotics@gmail.com> (cherry picked from commit 32aaef7)
christophfroehlich
force-pushed
the
mergify/bp/humble/pr-698
branch
from
4b37bd9
to
df051d3
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## humble #750 +/- ##
===========================================
+ Coverage 0 45.26% +45.26%
===========================================
Files 0 40 +40
Lines 0 3667 +3667
Branches 0 1732 +1732
===========================================
+ Hits 0 1660 +1660
- Misses 0 827 +827
- Partials 0 1180 +1180
Flags with carried forward coverage won't be shown. Click here to find out more.
|
christophfroehlich
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #698 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com