Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JTC] Adding tests for acceleration command interface #752

Merged

Conversation

christophfroehlich
Copy link
Contributor

@christophfroehlich christophfroehlich commented Aug 20, 2023

I found todos concerning acceleration tests:

  • Adds checks for acceleration command interfaces to
    • test_jumbled_joint_order and
    • test_partial_joint_list
  • Use variable for test_jumbled_joint_order goal.
  • Change logic of is_same_sign to is_same_sign_or_zero

Minor changes

  • use std namespace for copysign

If someone is thinking about the test trajectory points and the expected outputs of test_jumbled_joint_order
image

@codecov-commenter
Copy link

codecov-commenter commented Aug 20, 2023

Codecov Report

Merging #752 (eac5638) into master (e7f9962) will decrease coverage by 4.90%.
Report is 378 commits behind head on master.
The diff coverage is 25.91%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #752      +/-   ##
==========================================
- Coverage   35.78%   30.88%   -4.90%     
==========================================
  Files         189        7     -182     
  Lines       17570      832   -16738     
  Branches    11592      505   -11087     
==========================================
- Hits         6287      257    -6030     
+ Misses        994      133     -861     
+ Partials    10289      442    -9847     
Flag Coverage Δ
unittests 30.88% <25.91%> (-4.90%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...de/diff_drive_controller/diff_drive_controller.hpp 100.00% <100.00%> (ø)
...troller/include/diff_drive_controller/odometry.hpp 100.00% <100.00%> (ø)
...ontroller/test/test_load_diff_drive_controller.cpp 11.11% <0.00%> (ø)
diff_drive_controller/src/odometry.cpp 42.16% <11.11%> (ø)
diff_drive_controller/src/speed_limiter.cpp 46.55% <11.11%> (ø)
...iff_drive_controller/src/diff_drive_controller.cpp 47.13% <46.94%> (ø)
...ive_controller/test/test_diff_drive_controller.cpp 12.66% <7.81%> (ø)

... and 189 files with indirect coverage changes

Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

grand!

@bmagyar bmagyar merged commit f7c13ad into ros-controls:master Sep 27, 2023
14 checks passed
@bmagyar bmagyar added the backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble. label Sep 27, 2023
mergify bot pushed a commit that referenced this pull request Sep 27, 2023
christophfroehlich added a commit to christophfroehlich/ros2_controllers that referenced this pull request Oct 21, 2023
christophfroehlich added a commit to christophfroehlich/ros2_controllers that referenced this pull request Oct 21, 2023
christophfroehlich added a commit to christophfroehlich/ros2_controllers that referenced this pull request Nov 11, 2023
@christophfroehlich christophfroehlich deleted the jtc_acceleration_tests branch November 15, 2023 19:54
christophfroehlich added a commit to christophfroehlich/ros2_controllers that referenced this pull request Nov 15, 2023
christophfroehlich added a commit to christophfroehlich/ros2_controllers that referenced this pull request Nov 17, 2023
christophfroehlich added a commit to christophfroehlich/ros2_controllers that referenced this pull request Nov 27, 2023
christophfroehlich added a commit to christophfroehlich/ros2_controllers that referenced this pull request Nov 29, 2023
christophfroehlich added a commit to christophfroehlich/ros2_controllers that referenced this pull request Nov 30, 2023
christophfroehlich added a commit to christophfroehlich/ros2_controllers that referenced this pull request Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants