Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Resort overview page #846

Merged
merged 1 commit into from Nov 19, 2023

Conversation

christophfroehlich
Copy link
Contributor

A simple change to the overview page. If someone has a better title for Manipulators and Other Robots, let me know ;)

image

Controllers for Manipulators and Other Robots
*********************************************

The controllers are using `common hardware interface definitions`_, and may use namespaces depending on the following command interface types:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The controllers are using `common hardware interface definitions`_, and may use namespaces depending on the following command interface types:
These controllers are using `common hardware interface definitions`_, and may use namespaces depending on the following command interface types:

Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great job 👏

@christophfroehlich christophfroehlich added backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble. backport-iron This label should be used by maintaines only! Label triggers PR backport to ROS2 Iron. labels Nov 19, 2023
Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah this is great. Thank you!

@bmagyar bmagyar merged commit 25f2a14 into ros-controls:master Nov 19, 2023
10 of 14 checks passed
mergify bot pushed a commit that referenced this pull request Nov 19, 2023
(cherry picked from commit 25f2a14)
mergify bot pushed a commit that referenced this pull request Nov 19, 2023
(cherry picked from commit 25f2a14)
@christophfroehlich christophfroehlich deleted the docs/overview branch November 19, 2023 17:52
bmagyar pushed a commit that referenced this pull request Nov 20, 2023
bmagyar pushed a commit that referenced this pull request Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble. backport-iron This label should be used by maintaines only! Label triggers PR backport to ROS2 Iron.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants