[JTC] Remove read_only from 'joints', 'state_interfaces' and 'command… #967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_interfaces' parameters
github-actions
bot
requested review from
aprotyas,
bmagyar,
destogl,
livanov93,
olivier-stasse,
progtologist and
saikishor
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #967 +/- ##
=======================================
Coverage 47.82% 47.82%
=======================================
Files 41 41
Lines 3862 3862
Branches 1816 1816
=======================================
Hits 1847 1847
Misses 754 754
Partials 1261 1261
Flags with carried forward coverage won't be shown. Click here to find out more. |
bmagyar
approved these changes
Jan 11, 2024
bmagyar
added
backport-humble
Noel215
added a commit
to Noel215/ros2_controllers
that referenced
this pull request
Jan 17, 2024
…'command_interfaces' parameters (ros-controls#967)" This reverts commit 6e2736b.
destogl
pushed a commit
to Noel215/ros2_controllers
that referenced
this pull request
Jan 25, 2024
…'command_interfaces' parameters (ros-controls#967)" This reverts commit 6e2736b.
destogl
pushed a commit
that referenced
this pull request
Jan 26, 2024
destogl
pushed a commit
that referenced
this pull request
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #966
Needs backport to
humbleandiron.