Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add custom rosdoc2 config for ros2_controllers metapackage #1100

Merged
merged 8 commits into from
May 22, 2024
Merged

Add custom rosdoc2 config for ros2_controllers metapackage #1100

merged 8 commits into from
May 22, 2024

Conversation

christophfroehlich
Copy link
Contributor

@christophfroehlich christophfroehlich commented Apr 16, 2024 •
edited
Loading

rosdoc2 will be used by the build farm to publish API docs on http://docs.ros.org/en/rolling/p/ros2_control/ which is empty now.

  • Add custom landing page for rosdoc2: logo, links to control.ros.org
  • add rosdoc2 workflow, but only if the relevant files changed

image

@christophfroehlich christophfroehlich added backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble. backport-iron This label should be used by maintaines only! Label triggers PR backport to ROS2 Iron. labels Apr 16, 2024
@codecov Codecov
Copy link

codecov bot commented Apr 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.34%. Comparing base (0b43291) to head (29ab7fe).
Report is 20 commits behind head on master.

❗ Current head 29ab7fe differs from pull request most recent head 2031745

Please upload reports for the commit 2031745 to get more accurate results.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1100      +/-   ##
==========================================
- Coverage   71.86%   68.34%   -3.53%     
==========================================
  Files          41       92      +51     
  Lines        3650    10000    +6350     
  Branches     1794     6577    +4783     
==========================================
+ Hits         2623     6834    +4211     
- Misses        707      819     +112     
- Partials      320     2347    +2027
Flag Coverage Δ
unittests 68.34% <ø> (-3.53%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 51 files with indirect coverage changes

saikishor
saikishor approved these changes Apr 29, 2024
View reviewed changes
Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look fine to me

@christophfroehlich christophfroehlich merged commit 731da8e into master May 22, 2024
8 of 21 checks passed
@christophfroehlich christophfroehlich deleted the rosdoc2 branch May 22, 2024 17:23
mergify bot pushed a commit that referenced this pull request May 22, 2024
@christophfroehlich @mergify
Add custom rosdoc2 config for ros2_controllers metapackage (#1100)
860a506 
* Add simple rosdoc2 landing page

* Add link to package.xml

* Add links to controller docs on control.ros.org

* Set check-yaml syntax instead of ignoring

(cherry picked from commit 731da8e)
mergify bot pushed a commit that referenced this pull request May 22, 2024
@christophfroehlich @mergify
Add custom rosdoc2 config for ros2_controllers metapackage (#1100)
10d1887 
* Add simple rosdoc2 landing page

* Add link to package.xml

* Add links to controller docs on control.ros.org

* Set check-yaml syntax instead of ignoring

(cherry picked from commit 731da8e)
This was referenced May 22, 2024
Merged
Merged
christophfroehlich added a commit that referenced this pull request May 22, 2024
@mergify @christophfroehlich
Add custom rosdoc2 config for ros2_controllers metapackage (#1100) (#…
12a2ef2 
…1143)

* Add simple rosdoc2 landing page

* Add link to package.xml

* Add links to controller docs on control.ros.org

* Set check-yaml syntax instead of ignoring

(cherry picked from commit 731da8e)

Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
christophfroehlich added a commit that referenced this pull request May 22, 2024
@mergify @christophfroehlich
Add custom rosdoc2 config for ros2_controllers metapackage (#1100) (#…
25d8036 
…1142)

* Add simple rosdoc2 landing page

* Add link to package.xml

* Add links to controller docs on control.ros.org

* Set check-yaml syntax instead of ignoring

(cherry picked from commit 731da8e)

Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmauch fmauch fmauch approved these changes

@saikishor saikishor saikishor approved these changes

@bmagyar bmagyar Awaiting requested review from bmagyar

@destogl destogl Awaiting requested review from destogl

@jaron-l jaron-l Awaiting requested review from jaron-l

@moriarty moriarty Awaiting requested review from moriarty

@peterdavidfagan peterdavidfagan Awaiting requested review from peterdavidfagan

@VX792 VX792 Awaiting requested review from VX792

Assignees
No one assigned
Labels
backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble. backport-iron This label should be used by maintaines only! Label triggers PR backport to ROS2 Iron.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@christophfroehlich @fmauch @saikishor