Unused header cleanup #1199
Merged
Unused header cleanup #1199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
aprotyas,
arne48,
bijoua29,
bmagyar,
destogl,
livanov93 and
progtologist
henrygerardmoore
force-pushed
the
unused_header_cleanup
branch
from
f12d1fb
to
02e7408
Compare
Signed-off-by: Henry Moore <henry.moore2@technipfmc.com> Signed-off-by: Henry Moore <henry.moore@picknik.ai>
Signed-off-by: Henry Moore <henry.moore2@technipfmc.com> Signed-off-by: Henry Moore <henry.moore@picknik.ai>
Signed-off-by: Henry Moore <henry.moore2@technipfmc.com> Signed-off-by: Henry Moore <henry.moore@picknik.ai>
Signed-off-by: Henry Moore <henry.moore2@technipfmc.com> Signed-off-by: Henry Moore <henry.moore@picknik.ai>
Signed-off-by: Henry Moore <henry.moore2@technipfmc.com> Signed-off-by: Henry Moore <henry.moore@picknik.ai>
Signed-off-by: Henry Moore <henry.moore2@technipfmc.com> Signed-off-by: Henry Moore <henry.moore@picknik.ai>
Signed-off-by: Henry Moore <henry.moore2@technipfmc.com> Signed-off-by: Henry Moore <henry.moore@picknik.ai>
Signed-off-by: Henry Moore <henry.moore2@technipfmc.com> Signed-off-by: Henry Moore <henry.moore@picknik.ai>
Signed-off-by: Henry Moore <henry.moore2@technipfmc.com> Signed-off-by: Henry Moore <henry.moore@picknik.ai>
Signed-off-by: Henry Moore <henry.moore2@technipfmc.com> Signed-off-by: Henry Moore <henry.moore@picknik.ai>
Signed-off-by: Henry Moore <henry.moore2@technipfmc.com> Signed-off-by: Henry Moore <henry.moore@picknik.ai>
Signed-off-by: Henry Moore <henry.moore2@technipfmc.com> Signed-off-by: Henry Moore <henry.moore@picknik.ai>
Signed-off-by: Henry Moore <henry.moore2@technipfmc.com> Signed-off-by: Henry Moore <henry.moore@picknik.ai>
Signed-off-by: Henry Moore <henry.moore2@technipfmc.com> Signed-off-by: Henry Moore <henry.moore@picknik.ai>
Signed-off-by: Henry Moore <henry.moore2@technipfmc.com> Signed-off-by: Henry Moore <henry.moore@picknik.ai>
Signed-off-by: Henry Moore <henry.moore2@technipfmc.com> Signed-off-by: Henry Moore <henry.moore@picknik.ai>
Signed-off-by: Henry Moore <henry.moore2@technipfmc.com> Signed-off-by: Henry Moore <henry.moore@picknik.ai>
Signed-off-by: Henry Moore <henry.moore2@technipfmc.com> Signed-off-by: Henry Moore <henry.moore@picknik.ai>
…sourceManager (ros-controls#1184) Signed-off-by: Henry Moore <henry.moore2@technipfmc.com> Signed-off-by: Henry Moore <henry.moore@picknik.ai>
…itly set (ros-controls#1192) Signed-off-by: Henry Moore <henry.moore2@technipfmc.com> Signed-off-by: Henry Moore <henry.moore@picknik.ai>
Signed-off-by: Henry Moore <henry.moore2@technipfmc.com> Signed-off-by: Henry Moore <henry.moore@picknik.ai>
henrygerardmoore
force-pushed
the
unused_header_cleanup
branch
from
02e7408
to
acc7729
Compare
|
Sorry about the force pushes, was rebasing to use the correct signing key. |
|
Now that the CI is finally healthier, let's see how it does here! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1199 +/- ##
==========================================
- Coverage 86.58% 86.57% -0.02%
==========================================
Files 95 95
Lines 8586 8586
Branches 719 719
==========================================
- Hits 7434 7433 -1
Misses 883 883
- Partials 269 270 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
bmagyar
added
the
backport-iron
mergify bot
pushed a commit
that referenced
this pull request
Jul 16, 2024
(cherry picked from commit 96a8d57) # Conflicts: # joint_state_broadcaster/src/joint_state_broadcaster.cpp # joint_trajectory_controller/test/test_assets.hpp # pid_controller/src/pid_controller.cpp # tricycle_controller/include/tricycle_controller/odometry.hpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR just removes unused headers, replacing them with different ones where necessary. It also standardizes using
#include <gmock/gmock.h>as opposed to#include "gmock/gmock.h"(both were being used). Each commit is one package for convenience. The code still builds and the same tests seem to be failing as before. I don't notice any improvement in build speed, so this is just a style change.I used the clangd extension in vscode for this, though had to ignore a select few of its suggestions which caused build failures (particularly with
*_impl.hppfiles and similar.