Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JTC] Fix test_tolerances_via_actions #1209

Merged
merged 1 commit into from
Jul 16, 2024
Merged

[JTC] Fix test_tolerances_via_actions #1209

merged 1 commit into from
Jul 16, 2024
+8 −8

Conversation

christophfroehlich
Copy link
Contributor

@christophfroehlich christophfroehlich commented Jul 16, 2024 •
edited
Loading

Small changes were missing in #1192 for succeeding tests, reported here #1206 (comment)

Tested on jammy.

@christophfroehlich
Copy link
Contributor Author

@saikishor I can confirm that JTC tests are fine with #1206 on noble now

 $ colcon test --packages-select joint_trajectory_controller
Starting >>> joint_trajectory_controller
[Processing: joint_trajectory_controller]                                       
Finished <<< joint_trajectory_controller [5min 21s] 
Summary: 1 package finished [5min 21s]

@destogl destogl merged commit 0bb8880 into master Jul 16, 2024
6 of 19 checks passed
@destogl destogl deleted the fix/test_tolerances_via_actions branch July 16, 2024 08:02
saikishor
saikishor reviewed Jul 16, 2024
View reviewed changes
Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

destogl pushed a commit that referenced this pull request Jul 16, 2024
@mergify @fmauch @christophfroehlich
[JTC] Make goal_time_tolerance overwrite default value only if explic…
8d753a8 
…itly set (backport #1192 + #1209) (#1208)

---------

Co-authored-by: Felix Exner (fexner) <exner@fzi.de>
Co-authored-by: Christoph Froehlich <christoph.froehlich@ait.ac.at>
destogl pushed a commit that referenced this pull request Jul 16, 2024
@mergify @fmauch @christophfroehlich
[JTC] Make goal_time_tolerance overwrite default value only if explic…
c728db8 
…itly set (backport #1192 + #1209) (#1207)

---------

Co-authored-by: Felix Exner (fexner) <exner@fzi.de>
Co-authored-by: Christoph Froehlich <christoph.froehlich@ait.ac.at>
henrygerardmoore pushed a commit to henrygerardmoore/ros2_controllers that referenced this pull request Jul 19, 2024
@bmagyar
Reformat with braces added (ros-controls#1209)
562f36d
@destogl destogl mentioned this pull request Aug 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saikishor saikishor saikishor left review comments

@destogl destogl destogl approved these changes

@arne48 arne48 Awaiting requested review from arne48

@bmagyar bmagyar Awaiting requested review from bmagyar

@livanov93 livanov93 Awaiting requested review from livanov93

@mcbed mcbed Awaiting requested review from mcbed

@VX792 VX792 Awaiting requested review from VX792

@fmauch fmauch Awaiting requested review from fmauch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@christophfroehlich @destogl @saikishor