Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 Add PID controller 🎉 #434

Merged
merged 37 commits into from Dec 4, 2023

Conversation

destogl
Copy link
Member

@destogl destogl commented Sep 15, 2022

Proposal for a new controller that provides PID functionality.

The controller can be used stand-alone, in a chain.
Measured states can be provided through the topic or state interface, depening on the concrete control arch.
For example, if you are having an external estimator, using topic might be eaiser at first then full integration into ros2_control.

The PR depends the following changes:

Looking forward for your feedback!

Testing dependencies:

  control_msgs:
    type: git
    url: git@github.com:ros-controls/control_msgs.git
    version: add-generic-msgs-for-controller-references
  control_toolbox:
    type: git
    url: git@github.com:ros-controls/control_toolbox.git
    version: add-option-to-define-prefix-as-param-prefix
  ros2_controllers:
    type: git
    url: git@github.com:StoglRobotics-forks/ros2_controllers.git
    version: add-pid-controller

@destogl destogl self-assigned this Sep 15, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 15, 2022

Codecov Report

Merging #434 (d0cb6e2) into master (23f944f) will increase coverage by 0.60%.
The diff coverage is n/a.

❗ Current head d0cb6e2 differs from pull request most recent head 40b9360. Consider uploading reports for the commit 40b9360 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #434      +/-   ##
==========================================
+ Coverage   46.73%   47.33%   +0.60%     
==========================================
  Files          40       40              
  Lines        3640     3640              
  Branches     1718     1718              
==========================================
+ Hits         1701     1723      +22     
+ Misses        749      725      -24     
- Partials     1190     1192       +2     
Flag Coverage Δ
unittests 47.33% <ø> (+0.60%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

@mergify
Copy link
Contributor

mergify bot commented Nov 17, 2022

This pull request is in conflict. Could you fix it @destogl?

@destogl destogl marked this pull request as ready for review March 27, 2023 09:40
… be always updated. Enalbe option for Angle wraparound and add templates for the tests.
@bmagyar bmagyar merged commit 038a547 into ros-controls:master Dec 4, 2023
12 of 13 checks passed
@christophfroehlich
Copy link
Contributor

Can we backport this to iron and humble?

@destogl destogl deleted the add-pid-controller branch December 7, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet