-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misplaced param init in admittance_controller #547
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that the test should be adjusted into two tests. I am not sure if this can actually happen, what we are testing.
@guihomework any updates on this sir? |
Almost certain I can rework on this on the 3rd of April. Maybe earlier if I find a few minutes. Now still away from office. |
e1b4069
to
1b70772
Compare
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #547 +/- ##
==========================================
- Coverage 35.78% 32.48% -3.31%
==========================================
Files 189 7 -182
Lines 17570 665 -16905
Branches 11592 357 -11235
==========================================
- Hits 6287 216 -6071
+ Misses 994 157 -837
+ Partials 10289 292 -9997
Flags with carried forward coverage won't be shown. Click here to find out more.
|
on_configure should not be called if on_init failed but on_configure might fail for (future) parameter declaration happening there, so should still be tested against missing parameters
on_configure should not be called if on_init failed. Currently tested missing params all fail at on_init, so no need to test on_configure.
admittance_controller
was initializing theParamListener
twice inon_init
andon_configure
. This should not be required.However, without this, the test failed. The test was calling
on_configure
whenon_init
failed (due to a missing param). Now the test ensureson_init
fails, and if it does not (because all its params are available), then callson_configure
(which might require other params, as will be the case for future pluginlib-based filter loading).