-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt GH actions to target Foxy #98
Conversation
c252eda
to
726d5b5
Compare
197e100
to
1310ebc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is a big of a misnomer. The title suggests a fix which was done but you also disabled the industrial_ci job and codecov. Care to detail?
See my comment in ros-controls/ROS2-control#159 |
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
This reverts commit 8371698.
6d9f08d
to
12e9cab
Compare
I reverted the conditional given that we target only Foxy. Also adopted the description of the PR |
Co-authored-by: Denis Štogl <destogl@users.noreply.github.com>
* Rename get_controller to get_controllers * Restore get_loaded_controller and add deprecation warning
Turns out this was not a CI misconfiguration.ros2/rclcpp#1311 introduced an API break how callbacks for action goals are handled. Given that this (so far) only affects a single test, I don't see an immediate need for branching off and fixed the tests with a simple conditional given the version ofrclcpp
.Adapt GH actions: