Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert ForceTorqueSensorBroadcaster changes in PR #698 #988

Merged
merged 1 commit into from Jan 29, 2024
Merged

Revert ForceTorqueSensorBroadcaster changes in PR #698 #988

merged 1 commit into from Jan 29, 2024

Conversation

saikishor
Copy link
Member

The changes in this PR : #698 shouldn't be needed anymore after the newly merged parameter fix from : ros-controls/ros2_control#1293

@Noel215 can you please test it and let us know?

Thank you!

@saikishor saikishor changed the title Revert "[ForceTorqueSensorBroadcaster] Create ParamListener and get p… Revert ForceTorqueSensorBroadcaster changes in PR #698 Jan 25, 2024
destogl
destogl approved these changes Jan 26, 2024
View reviewed changes
Copy link
Member

@destogl destogl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@bmagyar bmagyar merged commit 7fee940 into ros-controls:master Jan 29, 2024
15 of 17 checks passed
@Noel215
Copy link
Contributor

Noel215 commented Jan 30, 2024

@saikishor I've cherry-picked this commit to humble and it works on real hardware.

@saikishor
Copy link
Member Author

Awesome, then we can backport these changes

@christophfroehlich christophfroehlich added backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble. backport-iron This label should be used by maintaines only! Label triggers PR backport to ROS2 Iron. labels Jan 30, 2024
mergify bot pushed a commit that referenced this pull request Jan 30, 2024
@saikishor @mergify
Revert "[ForceTorqueSensorBroadcaster] Create ParamListener and get p…
03ff50a 
…arameters on configure (#698)" (#988)

This reverts commit 32aaef7.

(cherry picked from commit 7fee940)
@mergify mergify bot mentioned this pull request Jan 30, 2024
Merged
mergify bot pushed a commit that referenced this pull request Jan 30, 2024
@saikishor @mergify
Revert "[ForceTorqueSensorBroadcaster] Create ParamListener and get p…
48bdb51 
…arameters on configure (#698)" (#988)

This reverts commit 32aaef7.

(cherry picked from commit 7fee940)
@mergify mergify bot mentioned this pull request Jan 30, 2024
Merged
bmagyar pushed a commit that referenced this pull request Jan 31, 2024
@mergify
Revert "[ForceTorqueSensorBroadcaster] Create ParamListener and get p…
b0c1330 
…arameters on configure (#698)" (#988) (#1003)
bmagyar pushed a commit that referenced this pull request Jan 31, 2024
@mergify
Revert "[ForceTorqueSensorBroadcaster] Create ParamListener and get p…
6285b43 
…arameters on configure (#698)" (#988) (#1004)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@destogl destogl destogl approved these changes

@bmagyar bmagyar bmagyar approved these changes

@DasRoteSkelett DasRoteSkelett Awaiting requested review from DasRoteSkelett

@livanov93 livanov93 Awaiting requested review from livanov93

@mcbed mcbed Awaiting requested review from mcbed

@peterdavidfagan peterdavidfagan Awaiting requested review from peterdavidfagan

@progtologist progtologist Awaiting requested review from progtologist

Assignees
No one assigned
Labels
backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble. backport-iron This label should be used by maintaines only! Label triggers PR backport to ROS2 Iron.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@saikishor @Noel215 @destogl @bmagyar @christophfroehlich