Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JointPositionController and friends unit tests #266

Open
bmagyar opened this issue Apr 23, 2017 · 3 comments
Open

JointPositionController and friends unit tests #266

bmagyar opened this issue Apr 23, 2017 · 3 comments

Comments

@bmagyar
Copy link
Member

bmagyar commented Apr 23, 2017

Reviewing #245 revealed that there are no unit tests for effort_controllers/XYController.
See here.
These controllers are mostly wrappers around the PID class but basic integration-level functionalities such as params and namespaces (just added) should still be tested.

@progtologist has kindly volunteered to add some of these.
@bmagyar
Copy link
Member Author

bmagyar commented May 9, 2017

ping @progtologist

@progtologist
Copy link
Member

@bmagyar I will look into it in a few days, sorry but I have been extremely busy this past month!

@bmagyar
Copy link
Member Author

bmagyar commented Jun 28, 2017

ping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@progtologist @bmagyar