Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Supply nh to urdf::Model #245

Merged
merged 1 commit into from
Apr 23, 2017
Merged

Supply nh to urdf::Model #245

merged 1 commit into from
Apr 23, 2017

Conversation

piyushk
Copy link
Contributor

@piyushk piyushk commented Dec 5, 2016

Merge after ros/robot_model#168

Closes #244

This was referenced Dec 5, 2016
Merged
Closed
@piyushk
Copy link
Contributor Author

piyushk commented Jan 30, 2017

@bmagyar I've updated this PR as per the discussion in ros/robot_model#168

@bmagyar
Copy link
Member

bmagyar commented Jan 31, 2017

Great! Thanks for updating. Please keep in mind that it'll take a short while for that PR changes to be released, I can only merge this one after that.

@liuzjmike liuzjmike mentioned this pull request Mar 28, 2017
Closed
@piyushk
Copy link
Contributor Author

piyushk commented Apr 19, 2017

Closing and reopening to trigger travis rebuild, since I don't have write permissions on this repository.

@piyushk piyushk closed this Apr 19, 2017
@piyushk piyushk reopened this Apr 19, 2017
@piyushk
Copy link
Contributor Author

piyushk commented Apr 19, 2017

@bmagyar: It looks like the PR is ready for review/merge. I was hoping to have the fix out before the next sync. Could you take a look again?

@bmagyar
Copy link
Member

bmagyar commented Apr 21, 2017 •
edited

👍 from me

@progtologist , what do you think? do you have anything to test this on directly?

@progtologist
Copy link
Member

👍 from me as well.
@bmagyar I don't have something ready right now and since syncing is right around the corner, merge this and I will make a unit test for testing this asap.

@bmagyar
Copy link
Member

bmagyar commented Apr 23, 2017

Deal. I'll take your word for it, but also open an issue as a kind reminder ;)

@bmagyar bmagyar merged commit 696633b into ros-controls:kinetic-devel Apr 23, 2017
This was referenced Apr 23, 2017
Open
Closed
wxmerkt added a commit to wxmerkt/ros_controllers that referenced this pull request Aug 25, 2020
@wxmerkt
[effort_controllers] JointGroupPositionController: Load URDF from nam…
a185a4f 
…espace

Mimics ros-controls#245
This was referenced Aug 25, 2020
Merged
Closed
bmagyar pushed a commit that referenced this pull request Aug 26, 2020
@wxmerkt @bmagyar
[effort_controllers] JointGroupPositionController: Load URDF from nam…
b603275 
…espace

Mimics #245
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmagyar bmagyar bmagyar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@piyushk @bmagyar @progtologist