-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more controllers support #303
Comments
Thanks for bringing this up. You may have noticed the overlap between these controllers and the ones in I agree that we should have a look at those controllers and see if they are worth porting over. |
It might be even possible to wrap the PR2 controller interface to our controller interface, but I think this is worth the effort only if the controllers are generic (as @bmagyar already pointed out). |
I was actually thinking to propose to the PR2 folks to consider
reimplementing the `pr2_controller_manager`-related software with
`ros_control` while keeping interface support but I think it'd almost be
the same anyways.
…On 3 November 2017 at 14:33, Mathias Lüdtke ***@***.***> wrote:
It might be even possible to wrap the PR2 controller interface to our
controller interface, but I this is worth the effort only if the
controllers are generic (as @bmagyar <https://github.com/bmagyar> already
pointed out).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#303 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADXH4QtBqpGKkEC4U11_X85u2MvhTXpcks5syyQ6gaJpZM4QQmB1>
.
|
I think it should be possible to transform them in ros_controllers, but I have two concerns:
|
Well... It turns out we don't actually have tests for any of our effort controllers and |
@jacknlliu any thoughts on this? |
@bmagyar A lot of times, I want to use the effort controller interface(including joint trajectory controller and cartesian space controller), but I searched many ROS packages, especially ROS-Industrial and the GitHub projects about ROS, I find that no works on this, especially work with gazebo. I think this is very important for modern robotics research in Gazebo and ROS. And I try to use the joint trajectory controller with effort interface, but we should first make the gravity compensation for Gazebo simulation robot, or the robot will not stable only with PID configuration about joint trajectory controller? An exploration about this, see Change the RRRBot to use torque control instead of position control by @JoshMarino. The same thing in joint velocity interface with Gazebo, see Controlling joints with velocity commands by @JenniferBuehler. I think that there is some work left unfinished. |
Gazebo has 2 approaches for this. One is through the Thanks for pointing out those posts, the comments and changes of the authors would be very much valued for fixing our tutorials. Using open-source and contributing back are essential for keeping things running. We can't go out hunting for posts telling if a tutorial is wrong, we are to be approached. The mode-switch should also be implemented for the Gazebo |
Thanks for letting me know about this. I was initially planning to make a PR proposing the addition of velocity controllers like the one I was playing around with, but haven't found the time yet. My package is now over a year old (or almost 2, oh time flies!) so it probably would need updating again anyway. If you think it would be really useful to have the sample velocity controller PR soon, I'll try to move this up in my TODO list :) |
hope you share your research about this up to date. @bmagyar What do you think about the PR proposing about new type velocity controller from @JenniferBuehler ? |
Hi, we have some solution for generic Cartesian controllers extending ros_control controllers and using moveIt IK-plugin interface to dynamically load different IKs. We tested them on multiple ros_control enabled robots and they work perfectly. Would this be of your interests? |
👍 could you share your codes about these? And is it tested with Gazebo RobotHW? |
I got many ros controllers from robot_mechanism_controllers , which including
Force/Impedance Controllers:
Could these support in ros controllers?
The text was updated successfully, but these errors were encountered: