Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dont wait when rospy.Duration(0) is set for timeout #231

Merged
merged 1 commit into from Apr 28, 2023

Conversation

knorth55
Copy link
Member

this PR add no wait mode when timout=rospy.Duration(0).

actionlib default behavior is that when we set rospy.Duration(0) for timeout, the client wait until result comes back.
this is a bit unnatural behavior, so I will change the behavior.

$ python say.py hello
[INFO] [1682567497.053644] [/say_387012_1682567495934:rosout]: Saying: hello
[INFO] [1682567497.056795] [/say_387012_1682567495934:rosout]: Voice: voice_kal_diphone
[INFO] [1682567497.059283] [/say_387012_1682567495934:rosout]: Volume: 1.0
[ERROR] [1682567498.205018] [/say_387012_1682567495934:rosout]: default elapsed_time: 1.1435973644256592
[ERROR] [1682567498.206991] [/say_387012_1682567495934:rosout]: no wait elapsed_time: 0.00020051002502441406

@knorth55 knorth55 merged commit 3a748b2 into ros-drivers:master Apr 28, 2023
5 checks passed
@knorth55 knorth55 deleted the no-wait-mode branch April 28, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant