Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spacenav_node - FULL_SCALE constant value #67

Open
ZdenekM opened this issue Jun 18, 2014 · 1 comment
Open

spacenav_node - FULL_SCALE constant value #67

ZdenekM opened this issue Jun 18, 2014 · 1 comment

Comments

@ZdenekM
Copy link

ZdenekM commented Jun 18, 2014

File spacenav_node.cpp contains FULL_SCALE definition (512) which is used for normalizing values for "joy" topic. Non-normalized values are available on "offset" topic and it seems that my device gives 350 as maximum instead of 512. If some devices really have 512 as the max. value I would propose to make FULL_SCALE configurable using parameter.

@ezekiel
Copy link

ezekiel commented Jun 19, 2015

looks like this was made configurable: 4a99592

Just recently, the changelog was also bumped which caused this change to finally make it into published .deb packages, dramatically changing spacenav_node message values.

To get the OLD behavior, one would need to set the "full_scale" parameter to "1" everywhere. To get PROPER new behavior, one would need to find your actual full_scale value and set that everywhere. Either way - MOST of the time, this will require an additional parameter.

Is "512" actually expected to work with some selection of the spacenav hardware? Would it not make sense to default to the old behavior (full_scale=1), or to a value that is common on more of the actual devices (full_scale=<???>) ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants