Compile fix for OSX #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is still valid, now more than before. I fixed some warnings which caused crashes on my current system (OSX 10.10). Specifically not returning values when a return type is specified is devastating. This caused a EXC_BAD_INSTRUCTION when running the system.. |
|
@mikeferguson could you look into this before it gets forgotten? |
|
@mikeferguson hate to be annoying, but this needs to be accepted for it to work on OSX. |
|
@mikeferguson Can this be added? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
usb_reset.c cannot compile on OSX, only on other UNIX systems. This skips the creating of that executable on OSX (and Windows?).