Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure libphidget22 library can be found. (#97) #100

Merged
merged 1 commit into from
Sep 8, 2021

Conversation

clalancette
Copy link
Contributor

In Foxy and later, we need to provide the .dsv hook so that
the library can be found.

Signed-off-by: Chris Lalancette clalancette@openrobotics.org

This is the same fix as #97, but for Galactic.

In Foxy and later, we need to provide the .dsv hook so that
the library can be found.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
@clalancette
Copy link
Contributor Author

@mintar friendly ping for review here, should be a simple one.

Copy link
Contributor

@mintar mintar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@clalancette
Copy link
Contributor Author

Thanks for the review, merging.

@clalancette clalancette merged commit 4c853f2 into galactic Sep 8, 2021
@clalancette clalancette deleted the clalancette/galactic-fix-hooks branch September 8, 2021 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants