Add pre-commit, move from travis to GitHub actions, fix style #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now everything passes the clang-check-style.py again.
This fixes the following catkin_lint warning:
warning: variable CMAKE_CXX_FLAGS is modified
From the CMake documentation: > The PROGRAMS form is identical to the FILES form except that the > default permissions for the installed file also include OWNER_EXECUTE, > GROUP_EXECUTE, and WORLD_EXECUTE. This form is intended to install > programs that are not targets, such as shell scripts. Since we are installing libraries, we don't want to set the executable bit. Also fixes catkin_lint warning "executable file is not installed to bin destination".
clalancette
approved these changes
Apr 8, 2022
There was a problem hiding this comment.
Yes please! This looks like a good thing to have; once we merge this, we should probably port over to the ROS 2 branches.
One thing is that I didn't see the workflow actually run in this PR. I thought that was supposed to happen when you initially added a .github/workflows file, but I don't see it. Any thoughts on what is going on there? Regardless, I think this is OK to merge in, as we can always do a follow-up with fixes.
|
I was wondering the same! Anyhow, now it's building for the merge commit (because it's a push): https://github.com/ros-drivers/phidgets_drivers/actions/runs/2116423918 Let's hope it will also build for future pull requests. Let's observe this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See separate commits for detailed descriptions.