BUGFIX: Z-channel index was not observed in reported positions #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
mintar
pushed a commit
that referenced
this pull request
Dec 23, 2022
* fix doxygen format and ensure initial values * BUGFIX: Encoder index was not used
|
Cherry-picked onto noetic, merged into humble and rolling. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For encoders with the Z-channel correctly wired to the Phidgets board, the incremental encoder positions were reported without taking into account the passes through zero, effectively ignoring the Z-channel effect.
This only affected positions, not velocities.
PS: As usual, the same patch should be applied to all branches...