Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to libphidget22 1.19 #176

Merged
merged 1 commit into from Mar 13, 2024

Conversation

mintar
Copy link
Contributor

@mintar mintar commented Mar 13, 2024

This version of libphidget22 compiles without warnings, so we don't need the patch file any more.

@mintar
Copy link
Contributor Author

mintar commented Mar 13, 2024

This is a port of #175 to ROS2.

This version of libphidget22 compiles without warnings, so we don't need the patch file any more.
@mintar mintar force-pushed the update-libphidget-1.19-rolling branch from f59ebb0 to a21b491 Compare March 13, 2024 12:17
@mintar
Copy link
Contributor Author

mintar commented Mar 13, 2024

There seem to be two different build errors:

  1. ROS build farm:

    13:18:23 Step 26/35 : RUN pip3 install -U setuptools==59.6.0
    13:18:23  ---> Running in 400d80ac7b16
    13:18:23 �[91merror: externally-managed-environment
    
  2. GitHub actions for Rolling:

ERROR: the following packages/stacks could not have their rosdep keys resolved
to system dependencies:
phidgets_gyroscope: No definition of [ament_cmake_ros] for OS version [jammy]

AFAICT:

re. 1.: The build farm is just acting up again, the error is unrelated and should be fixed when the build farm is fixed.

re. 2.: Seems like the rolling rosdep support for Ubuntu 22.04 has been removed; rolling has probably already rolled over to Ubuntu Noble 24.04? That's a bit of a shame because 24.04 is not released yet, and consequently GitHub actions doesn't provide it yet.

Since this PR builds successfully on humble and iron, I suggest we merge this into humble, iron and rolling, and after Ubuntu 24.04 becomes available for GitHub we fix that build error in a different PR.

@clalancette: Any thoughts?

@mintar mintar requested a review from clalancette March 13, 2024 12:34
@clalancette
Copy link
Contributor

re. 1.: The build farm is just acting up again, the error is unrelated and should be fixed when the build farm is fixed.

re. 2.: Seems like the rolling rosdep support for Ubuntu 22.04 has been removed; rolling has probably already rolled over to Ubuntu Noble 24.04? That's a bit of a shame because 24.04 is not released yet, and consequently GitHub actions doesn't provide it yet.

Yes, this is exactly right; all of this has to do with the transition to Ubuntu 24.04, which we are still in the midst of. Given that Humble and Iron are passing, I'm fine with merging this as-is.

@mintar mintar merged commit 8e4dcf7 into ros-drivers:rolling Mar 13, 2024
2 of 4 checks passed
@mintar mintar deleted the update-libphidget-1.19-rolling branch March 13, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants