Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the ROS 2 readme files. #93

Merged
merged 1 commit into from
May 27, 2021

Conversation

clalancette
Copy link
Contributor

This adds more information about running the nodes.

Signed-off-by: Chris Lalancette clalancette@openrobotics.org

@tim-fan I'd appreciate a look over this by you to see if it gives you the information you needed.

Fixes #92

This adds more information about running the nodes.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
@clalancette clalancette requested a review from mintar May 26, 2021 13:22
Copy link
Contributor

@mintar mintar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tim-fan
Copy link
Contributor

tim-fan commented May 27, 2021

LGTM too.
Thanks for the quick turn around and additional explanation about the rationale for components 👍

@clalancette clalancette merged commit 0a4e583 into galactic May 27, 2021
@clalancette clalancette deleted the clalancette/update-ros2-readme branch May 27, 2021 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants