Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should prevent multiple camera nodes from conflicting. #11

Merged
merged 1 commit into from
Aug 8, 2014

Conversation

wnoise
Copy link

@wnoise wnoise commented Aug 8, 2014

Always loading nodelets into the same process gets conflicts. Now each node loads its own copy.

@mikepurvis
Copy link
Member

I don't understand the change— is this for the nodelet or the node?

@wnoise
Copy link
Author

wnoise commented Aug 8, 2014

For the node -- as it works as a nodelet manager and loads the nodelet, it needs a unique name, just as real nodelet managers do. Running two nodes at the same time confuses the nodelet loading code.

Without this, I can't run multiple cameras as nodes, nor as nodelets sharing a single manager, but can as nodelets with separate managers. With this, I can run multiple cameras as nodes and as nodelets with separate managers, but not as nodelets sharing a single manager.

@mikepurvis
Copy link
Member

The typical usage model for cameras is as a nodelet, but making the node wrapper slightly friendlier harms nothing. Thanks!

mikepurvis added a commit that referenced this pull request Aug 8, 2014
Should prevent multiple camera nodes from conflicting.
@mikepurvis mikepurvis merged commit 61a6beb into ros-drivers:master Aug 8, 2014
@wnoise wnoise deleted the multinodes branch August 29, 2014 01:15
miguelriemoliveira pushed a commit to lardemua/pointgrey_camera_driver that referenced this pull request May 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants