Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing formatting on files. #333

Merged
merged 1 commit into from Nov 9, 2017
Merged

Conversation

@mikeodr
Copy link
Contributor

mikeodr commented Nov 9, 2017

Astyle fixup.

Ran the following in the repo:

find -regextype egrep -regex '.*\.[ch](pp)?$' -exec astyle '{}' --style=allman --indent=spaces=2 --pad-oper --unpad-paren --pad-header --convert-tabs \;
@mikepurvis

This comment has been minimized.

Copy link
Member

mikepurvis commented Nov 9, 2017

I was picturing just doing rosserial_client— my main worry about the other repos is that there's some vendor code in there that probably shouldn't be restyled.

That said, maybe it does make sense to just fix everything?

@mikeodr

This comment has been minimized.

Copy link
Contributor Author

mikeodr commented Nov 9, 2017

Will pair it back then.

Mike O'Driscoll
find -regextype egrep -regex '.*\.[ch](pp)?$' -exec astyle '{}' --style=allman --indent=spaces=2 --pad-oper
--unpad-paren --pad-header --convert-tabs \;
@mikeodr mikeodr force-pushed the mikeodr:astyle-fixup branch from a163701 to 2d9229b Nov 9, 2017
@mikepurvis

This comment has been minimized.

Copy link
Member

mikepurvis commented Nov 9, 2017

Thanks, that is much more manageable.

@mikepurvis mikepurvis merged commit 80ab547 into ros-drivers:jade-devel Nov 9, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
romainreignier pushed a commit to 1r0b1n0/rosserial that referenced this pull request Nov 7, 2018
…am to jade-devel

* commit 'a707373c7e9f9ad40ad9440550840e29960c9290':
  Changed hardcoded pin 13 to LED_BUILTIN (ros-drivers#328)
  Re-attempting rosserial for VEX Cortex (ros-drivers#380)
  Added service to force an Arduino hard reset in serial_node.py (ros-drivers#349)
  Fix compiling on boost > 1.66 (ros-drivers#362)
  Use the ! prefix introduced in gcc4mbed for mbed examples (ros-drivers#304)
  Add support for boolean parameters (ros-drivers#355)
  Change Travis to use clang-5.0.0 (ros-drivers#363)
  [python] fix an unboundlocalerror (ros-drivers#346)
  Added ESP32 support (ros-drivers#345)
  Retry opening the serial port every 3 seconds (ros-drivers#342)
  In rosserial_arduino, changed embedded type size for ROS uint64 to 8 bytes from 4. (ros-drivers#312)
  0.7.7
  Changes
  Copy src/examples to install dir so make_libraries.py doesn't fail (ros-drivers#336)
  Add overall spin timeout to rosserial read. (ros-drivers#334)
  Fixing formatting on files. (ros-drivers#333)
  Fix catkin lint errors (ros-drivers#296)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.