Remove ESP flags for ArduinoTcpHardware to use hardware serial #559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If the serial path works without any more changes, this seems ok but the esp8266 example should be changed to add the |
|
Thank you for the feedback. |
asukiaaa
force-pushed
the
feature/remove-esp-flag-for-arduino-tcp-hardware
branch
from
af05341
to
278eae5
Compare
|
This seems reasonable and non-breaking. Thanks for the change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to use HardwareSerial with ESP32.
Could you consider removing ESP flags to activate ArduinoTcpHardware?
Thanks.