Bugfix: when no device ip is set, we still want to filter by udp port. #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JWhitleyWork
approved these changes
Jul 24, 2018
There was a problem hiding this comment.
Looks correct. Only applies to pcap playback so IP address shouldn't be required. The only caveat to this is that providing no IP address will read all packets from all devices provided in the PCAP file and publish them on the same topic. However, if IP filtering is required, an IP address can be provided.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Theres a bug when playing back pcap files that contain packets from another udp port (!= 2368). The pcap filter is not applied when the device ip is not set, which leads to incorrect playback of the file.